Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expose the logs dir outside of the production container #1001

Merged
merged 4 commits into from
Aug 27, 2024
Merged

expose the logs dir outside of the production container #1001

merged 4 commits into from
Aug 27, 2024

Conversation

DaanVanVugt
Copy link
Contributor

Summary of changes

  • mount the logs dir to /code/logs

Motivation and context

Ingestor debugging is hard without seeing the logs.

Checklist

  • I have read and followed the CONTRIBUTING guide.
  • I confirm that I have the authority necessary to make this contribution on behalf of its copyright owner and agree
    to license it to the TeSS codebase under the
    BSD license.

fbacall
fbacall requested changes Jul 30, 2024
View reviewed changes
Copy link
Member

@fbacall fbacall left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed the build error, the log volume needs to be listed in the "volumes" section at the end.

Or maybe should be ./log?

fbacall
fbacall requested changes Aug 1, 2024
View reviewed changes
Copy link
Member

@fbacall fbacall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets call it logs

@fbacall fbacall merged commit 056332d into ElixirTeSS:master Aug 27, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbacall fbacall fbacall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DaanVanVugt @fbacall @mikesndrs